Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug backports #335

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Bug backports #335

merged 2 commits into from
Oct 10, 2019

Conversation

agubler
Copy link
Member

@agubler agubler commented Oct 10, 2019

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Backports of #333 and #334

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #335 into v6 will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v6     #335   +/-   ##
=======================================
  Coverage   48.39%   48.39%           
=======================================
  Files          10       10           
  Lines         686      686           
  Branches      195      195           
=======================================
  Hits          332      332           
  Misses        354      354
Impacted Files Coverage Δ
src/base.config.ts 19.65% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f088f9f...710569b. Read the comment docs.

@agubler
Copy link
Member Author

agubler commented Oct 10, 2019

Merging cherry-picked backports for v6

@agubler agubler merged commit 27b78ad into dojo:v6 Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant