Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hostname to last argument on mac #18

Closed
dopecodez opened this issue Oct 3, 2020 · 0 comments · Fixed by #20
Closed

Move hostname to last argument on mac #18

dopecodez opened this issue Oct 3, 2020 · 0 comments · Fixed by #20
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@dopecodez
Copy link
Owner

As per PR #12 , we moved the hostname to the last argument on the ping command on linux.

I propose we do the same for Mac so as to maintain uniformity between the UNIX platforms.

All we need to do is follow the steps as in #12.

  • Move hostname to last argument in src/builder/mac.ts
  • Adjust the tests in test/builder/builder.ts

I'll take this up once i get the time. Anyone who wants to work on this on the meantime, can comment here if you want a more detailed idea about what we're trying to achieve.

@dopecodez dopecodez added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 3, 2020
JesseVermeulen123 added a commit to JesseVermeulen123/pingman that referenced this issue Oct 25, 2020
dopecodez pushed a commit that referenced this issue Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant