Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hostname to last argument on linux #12

Merged
merged 4 commits into from
Jul 17, 2020
Merged

Move hostname to last argument on linux #12

merged 4 commits into from
Jul 17, 2020

Conversation

luludotdev
Copy link
Contributor

Fixes #11

@luludotdev luludotdev marked this pull request as draft July 16, 2020 23:56
@luludotdev luludotdev marked this pull request as ready for review July 16, 2020 23:58
@dopecodez
Copy link
Owner

Other than that, the PR looks good. It's an interesting workaround, that the host must come as the last entry. I know it works in Mac with the entry in the beginning, but perhaps we should think about making it similar just to maintain uniformity between the UNIX platforms.

dopecodez
dopecodez requested changes Jul 17, 2020
View reviewed changes
test/builder/builder.ts Outdated Show resolved Hide resolved
@dopecodez
Copy link
Owner

Thanks for the PR, @lolPants

@dopecodez dopecodez merged commit 4b6f0e8 into dopecodez:develop Jul 17, 2020
dopecodez added a commit that referenced this pull request Jul 18, 2020
@dopecodez @luludotdev
Move hostname to last argument on linux (#12) (#13)
9061263 
* move hostname to last argument on linux

* fix hostname not being set

* modify tests

* remove unwanted console.log

Co-authored-by: Jack Baron <jackmbaron@gmail.com>
@dopecodez dopecodez mentioned this pull request Oct 3, 2020
Closed
@dopecodez dopecodez mentioned this pull request Oct 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopecodez dopecodez dopecodez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not work on Alpine Linux
2 participants
@luludotdev @dopecodez