Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass directory path from call-site #7984

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Conversation

am11
Copy link
Member

@am11 am11 commented Oct 1, 2021

When init-compiler is sourced (as opposed to eval'd), the script was
throwing an error: pipeline-logging-functions.sh: No such file or directory.

Reflecting changes from dotnet/runtime#59858.

@am11
Copy link
Member Author

am11 commented Oct 1, 2021

cc @jkoritzinsky, @janvorli

@jkoritzinsky
Copy link
Member

We might need to make changes in dotnet/diagnostics as well to react to this. Can we solve this problem differently (without making a breaking change for the script)?

@am11
Copy link
Member Author

am11 commented Oct 1, 2021

@jkoritzinsky, dotnet/diagnostics does not use anything from shared location which we have just started to use. It doesn't even use the latest of dotnet/coreclr (it is super old and stale version..).

@am11
Copy link
Member Author

am11 commented Oct 1, 2021

I knew this off-hand, because I already have a WIP branch to close the gap between diagnostics config: dotnet/diagnostics@main...am11:feature/build-infra rejuvenation in progress.. 😉

We may want to share more scripts via eng/common/native between runtime and diagnostics. That's something I will follow up with you, @hoyosjs and @janvorli once I have diagnostics PR up (but it is unrelated to the changes here which only fix a warning in runtime).

@jkoritzinsky jkoritzinsky merged commit b3364cf into dotnet:main Oct 1, 2021
@am11 am11 deleted the feature/configs branch October 1, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants