-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass directory path from call-site #59858
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
cc @jkoritzinsky, @janvorli, noticed this when I was looking at mono logs for another issue: https://dev.azure.com/dnceng/public/_build/results?buildId=1397492&view=logs&j=38c63b74-c97f-5bda-376d-1084248ecb57&t=b7130259-7da2-5518-9023-82792e689970&l=98 In gen-buildsys.sh, it doesn't warn because we are at the same relative distance. |
aa2dccb
to
a59ed9b
Compare
(the build still continues and succeeds because it's not running with
It regressed in #59018. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
win x64 failure is unrelated to PR changes: #29683. |
When init-compiler is sourced (as opposed to
eval
'd), the script was giving a non-fatal error, e.g. on mono x64:pipeline-logging-functions.sh: No such file or directory
. We use Azure logging functions in error cases, so it went unnoticed.This PR uses the same simple mechanism for sourced scripts we have used in other places; pass the directory path from all call-sites as an argument. Also quoted the positional arguments.