-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WaitFor: SQL Server #5669
WaitFor: SQL Server #5669
Conversation
ca75faa
to
995e875
Compare
playground/SqlServerEndToEnd/SqlServerEndToEnd.Common/SqlServerEndToEnd.Common.csproj
Outdated
Show resolved
Hide resolved
playground/SqlServerEndToEnd/SqlServerEndToEnd.DbSetup/SqlServerEndToEnd.DbSetup.csproj
Outdated
Show resolved
Hide resolved
In a separate PR we should add the |
tests/Aspire.Hosting.SqlServer.Tests/SqlServerFunctionalTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
…otnet/aspire into mitchdenny/wait-for-sql-server
Aspire.Hosting.Dcp.dcpctrl.NetworkReconciler Error: could not create a network {"NetworkName": {"name":"aspire-network"}, "Reconciliation": 2, "error": "docker command 'CreateNetwork' returned with non-zero exit code 1: command output: Stdout: '' Stderr: 'Error response from daemon: could not find an available, non-overlapping IPv4 address pool among the defaults to assign to the network\n'"} Seems like we're not cleaning up the network properly? |
@radical I reverted the target framework changes. None of the other sames seem to have that. |
Oh they do on main now. I'm going to merge with main. |
Description
Adds SQL Server support for WaitFor (still needs unit tests and some validation around Azure SQL deployments).
Related: #5645
Checklist
<remarks />
and<code />
elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow