-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WaitFor: Add health checks to remaining resources #5645
Comments
@mitchdenny , I could help you to completing this one. |
Lets do the azure resources last. |
@Alirexaa of course! Any help is welcome with this. Let's tackle each resource in a different PR and just update the issue with a link to your PR as you work on it. |
I will work on Valkey |
I will work on Milvus. |
Kakfka is high on the priority list. |
I sorted the list in priority order |
I will work on Elasicseach. |
I will work on Oracle. |
Added PgAdmin. That will be useful to add health checks for since its so slow to start. That'll give us a visual indicator in the dashboard that it's healthy. |
I will work in nats. |
Is the health check primarily for the visual indicator. It's not that common that anyone will do a var builder = DistributedApplication.CreateBuilder(args);
var pgsql = builder.AddPostgres("pgsql");
var db = pgsql.AddDatabase("db");
var app = builder.AddProject<Projects.MyApp>("app")
.WithReference(db).WaitFor(db);
pgsql.WithPgAdmin(c => {
app.WaitFor(c); // Causes app to block loading until pgadmin is running/healthy.
}); |
Seq and Qdrant resources are missing. |
I will work on Qdrant. |
With the merge of #5394 and some of the subsequent enhancements around health check integration (#5515) its now time to scale out the support for WaitFor for all of our resources. Essentially each
AddXYZ
method for a resource needs to register a health check with DI and add a matchingHealthCheckAnnotation
. Here are two examples:Redis
aspire/src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs
Lines 36 to 57 in 1b2e640
Postgres
aspire/src/Aspire.Hosting.PostgreSQL/PostgresBuilderExtensions.cs
Lines 38 to 98 in 1b2e640
Remaining resources
Pri0
P1
P2
Some of these resources don't have health checks and possibly won't need them but we should go through the list and very each one and create issues. We also need test coverage for the WaitFor behavior to verify that it is working as expected for each resource (example):
aspire/tests/Aspire.Hosting.Redis.Tests/RedisFunctionalTests.cs
Lines 21 to 68 in 1b2e640
The text was updated successfully, but these errors were encountered: