Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaitFor for Kafka #5719

Merged
merged 3 commits into from
Sep 16, 2024
Merged

WaitFor for Kafka #5719

merged 3 commits into from
Sep 16, 2024

Conversation

mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Sep 15, 2024

Description

Adds support for WaitFor for Kafka (note, in draft because I'm debugging an issue with the test case although works fine with the playground app).

Related #5645

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Sep 15, 2024
@davidfowl davidfowl added area-integrations Issues pertaining to Aspire Integrations packages kafka Issues related to Kafka integrations and removed area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication labels Sep 15, 2024
@mitchdenny mitchdenny marked this pull request as ready for review September 16, 2024 03:28
@davidfowl
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny merged commit 65c6902 into main Sep 16, 2024
11 checks passed
@mitchdenny mitchdenny deleted the mitchdenny/waitfor-kafka branch September 16, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages kafka Issues related to Kafka integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants