Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaitFor support for Garnet. #5698

Merged
merged 1 commit into from
Sep 13, 2024
Merged

WaitFor support for Garnet. #5698

merged 1 commit into from
Sep 13, 2024

Conversation

mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Sep 13, 2024

Description

Adds a health check to the host for Garnet resource so that it works with WaitFor.

Fixes #5645

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@davidfowl davidfowl added area-integrations Issues pertaining to Aspire Integrations packages and removed area-components labels Sep 13, 2024
@mitchdenny mitchdenny merged commit c18fedf into main Sep 13, 2024
11 checks passed
@mitchdenny mitchdenny deleted the mitchdenny/waitfor-garnet branch September 13, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WaitFor: Add health checks to remaining resources
2 participants