Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blazor WebAssembly AOT publiish output contains files that should not be published #32744

Closed
danroth27 opened this issue May 16, 2021 · 4 comments · Fixed by dotnet/sdk#19873
Closed

Blazor WebAssembly AOT publiish output contains files that should not be published #32744

danroth27 opened this issue May 16, 2021 · 4 comments · Fixed by dotnet/sdk#19873
Assignees
@javiercn
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. feature-blazor-aot-compilation This issue is related to AoT compilation of Blazor WebAssembly apps feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Milestone
6.0-rc2

Comments

@danroth27
Copy link
Member

Repro steps:

  • Install .NET 6 Preview 4 (6.0.100-preview.4.21255.9)
  • AOT compile a Blazor WebAssembly app by publishing it
  • Inspect the published output

Expected result:

  • Only files that should be published with the app are present in the published wwwroot folder

Actual result:

  • Published output contains C code, header files, and other implementation files like:
    • corebindings.c
    • driver.c
    • pinvoke.c
    • pinvoke.h
    • emcc-flags.txt
    • emcc-version.txt
    • etc.

@lewing @pranavkm
@javiercn javiercn added area-blazor Includes: Blazor, Razor Components feature-blazor-aot-compilation This issue is related to AoT compilation of Blazor WebAssembly apps feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels May 17, 2021
@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label May 17, 2021
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone May 17, 2021
@ghost
Copy link

ghost commented May 17, 2021

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@mkArtakMSFT
Copy link
Member

This is most probably caused by the runtime. Will talk to them and update this issue accordingly.

@mkArtakMSFT
Copy link
Member

@eerhardt do you have a tracking issue for this that we can dupe this against?

@eerhardt
Copy link
Member

Seems to be a dupe of dotnet/runtime#48016 (mostly). I guess I wrote it as .c and .h files, but this also lists .txt files.

@eerhardt eerhardt mentioned this issue May 17, 2021
Closed
@javiercn javiercn mentioned this issue Aug 20, 2021
Merged
javiercn added a commit to dotnet/sdk that referenced this issue Aug 20, 2021
@javiercn
[Static web assets] Several fixes for additional scenarios
843f0f9 
* Fixes an issue with projects not working with reference assemblies
  using HintPath.
* Fixes an issue where files without an extension where being included
  inside an additional folder with the file name on nuget packages.
* Adds additional error logging for the brotli compression tool.
* Adds additional login for the gzip compress task.
* Adds editor config files in the blazor wasm and razor sdk folders
  to handle 'var' usage preferences in ASP.NET Core projects.
* Performs a more selective filtering for static web assets candidates
  from the build candidates in blazor webassembly applications.
* Fixes an issue with AppendTargetFramework=false causing issues

dotnet/aspnetcore#35349
dotnet/aspnetcore#32744
dotnet/aspnetcore#29561
dotnet/aspnetcore#35561
javiercn added a commit to dotnet/sdk that referenced this issue Aug 20, 2021
@javiercn
[Static web assets] Several fixes for additional scenarios
92c9e7d 
* Fixes an issue with projects not working with reference assemblies
  using HintPath.
* Fixes an issue where files without an extension where being included
  inside an additional folder with the file name on nuget packages.
* Adds additional error logging for the brotli compression tool.
* Adds additional login for the gzip compress task.
* Adds editor config files in the blazor wasm and razor sdk folders
  to handle 'var' usage preferences in ASP.NET Core projects.
* Performs a more selective filtering for static web assets candidates
  from the build candidates in blazor webassembly applications.
* Fixes an issue with AppendTargetFramework=false causing issues

dotnet/aspnetcore#35349
dotnet/aspnetcore#32744
dotnet/aspnetcore#29561
dotnet/aspnetcore#35561
@javiercn javiercn mentioned this issue Aug 20, 2021
Merged
4 tasks
javiercn added a commit to dotnet/sdk that referenced this issue Aug 24, 2021
@javiercn
[Static web assets] Several fixes for additional scenarios (#19963)
bd8d08f 
* Fixes an issue with projects not working with reference assemblies
  using HintPath.
* Fixes an issue where files without an extension where being included
  inside an additional folder with the file name on nuget packages.
* Adds additional error logging for the brotli compression tool.
* Adds additional login for the gzip compress task.
* Adds editor config files in the blazor wasm and razor sdk folders
  to handle 'var' usage preferences in ASP.NET Core projects.
* Performs a more selective filtering for static web assets candidates
  from the build candidates in blazor webassembly applications.
* Fixes an issue with AppendTargetFramework=false causing issues

dotnet/aspnetcore#35349
dotnet/aspnetcore#32744
dotnet/aspnetcore#29561
dotnet/aspnetcore#35561
@ghost ghost locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@javiercn javiercn

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. feature-blazor-aot-compilation This issue is related to AoT compilation of Blazor WebAssembly apps feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects
None yet
Milestone
6.0-rc2
Development

Successfully merging a pull request may close this issue.

[Static web assets] Account for HintPath when we compute the build assets dotnet/sdk
5 participants
@SteveSandersonMS @danroth27 @javiercn @eerhardt @mkArtakMSFT