Backport https://github.com/dotnet/sdk/pull/19873 to RC1 #19963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes an issue with projects not working with reference assemblies using HintPath. * Fixes an issue where files without an extension where being included inside an additional folder with the file name on nuget packages. * Adds additional error logging for the brotli compression tool. * Adds additional login for the gzip compress task. * Adds editor config files in the blazor wasm and razor sdk folders to handle 'var' usage preferences in ASP.NET Core projects. * Performs a more selective filtering for static web assets candidates from the build candidates in blazor webassembly applications. * Fixes an issue with AppendTargetFramework=false causing issues dotnet/aspnetcore#35349 dotnet/aspnetcore#32744 dotnet/aspnetcore#29561 dotnet/aspnetcore#35561
javiercn
added
Area-AspNetCore
javiercn
changed the title
|
I'm in favor of this fix for RC1, given the VS Feedback items behind it. |
pranavkm
approved these changes
Aug 24, 2021
|
@pranavkm who is coordinating that |
|
I'll discuss it today at Tactics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small fixes to some more advanced scenarios for static web assets
Customer Impact
Some existing customers aren't able to update to the latest preview due to some of the issues. Specifically:
Other changes are fixes to other scenarios we believe didn't work before either
Regression?
Preview6
Risk
We have extensive end to end test coverage (all fixes include new automation to validate the scenarios) and the changes don't affect core scenarios.
Verification
dotnet/aspnetcore#35349
dotnet/aspnetcore#32744
dotnet/aspnetcore#29561
dotnet/aspnetcore#35561