Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Cases of table splitting when table cannot give all the columns #20338

Closed
smitpatel opened this issue Mar 18, 2020 · 1 comment · Fixed by #20345
Closed

Query: Cases of table splitting when table cannot give all the columns #20338

smitpatel opened this issue Mar 18, 2020 · 1 comment · Fixed by #20345
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

Most notably if Distinct is applied causing pushdown.
@AndriySvyryd AndriySvyryd mentioned this issue Mar 19, 2020
Open
4 tasks
@smitpatel smitpatel self-assigned this Mar 19, 2020
@smitpatel
Copy link
Member Author

Fixed this by injecting columns into inner select expression and lifting them outside. Given it is entityType fully selected, adding table splitting columns in distinct should not cause any change.

@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 19, 2020
@smitpatel smitpatel added this to the 5.0.0 milestone Mar 19, 2020
smitpatel added a commit that referenced this issue Mar 19, 2020
@smitpatel
Query: Do not generate server side joins for optional dependents
5fe3628 
Fix involves:
- Adding additional materialization conditions for relational layer when table splitting is used. See #20332 for conditions
- Create EntityProjection using the same table when both types are sharing the table.
- Fix a bug in shaper when null entityType is returned from materialization condition, don't call StartTracking.
- Assign nullability to PK column correctly for optional dependents so we don't project it twice.
- Disabled Sql assertion in OwnedQuerySqlServerTest. Will enable after model update as described in #20336, #20343

Resolves #18299
Resolves #20338
Resolves #20332
@smitpatel smitpatel mentioned this issue Mar 19, 2020
Merged
smitpatel added a commit that referenced this issue Mar 20, 2020
@smitpatel
Query: Do not generate server side joins for optional dependents
0ccab1a 
Fix involves:
- Adding additional materialization conditions for relational layer when table splitting is used. See #20332 for conditions
- Create EntityProjection using the same table when both types are sharing the table.
- Fix a bug in shaper when null entityType is returned from materialization condition, don't call StartTracking.
- Assign nullability to PK column correctly for optional dependents so we don't project it twice.
- Disabled Sql assertion in OwnedQuerySqlServerTest. Will enable after model update as described in #20336, #20343

Resolves #18299
Resolves #20338
Resolves #20332
@smitpatel smitpatel linked a pull request Mar 20, 2020 that will close this issue
Query: Do not generate server side joins for optional dependents #20345
Merged
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview3 Mar 31, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview3, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Do not generate server side joins for optional dependents dotnet/efcore
2 participants
@ajcvickers @smitpatel