Query: Do not generate server side joins for optional dependents #20345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix involves: - Adding additional materialization conditions for relational layer when table splitting is used. See #20332 for conditions - Create EntityProjection using the same table when both types are sharing the table. - Fix a bug in shaper when null entityType is returned from materialization condition, don't call StartTracking. - Assign nullability to PK column correctly for optional dependents so we don't project it twice. - Disabled Sql assertion in OwnedQuerySqlServerTest. Will enable after model update as described in #20336, #20343 Resolves #18299 Resolves #20338 Resolves #20332
smitpatel
added a commit
that referenced
this pull request
Mar 19, 2020
- Also add at least one additional property in each owned type. If there no columns other than shared PK then it is required dependent. - Add a property in owned type which would be sharing column for hierarchy. Currently disabled due to #20334 Resolves #20343 Resolves #20336 Finishes left over test work from #20345
smitpatel
added a commit
that referenced
this pull request
Mar 19, 2020
- Also add at least one additional property in each owned type. If there no columns other than shared PK then it is required dependent. - Add a property in owned type which would be sharing column for hierarchy. Currently disabled due to #20334 Resolves #20343 Resolves #20336 Finishes left over test work from #20345
maumar
reviewed
Mar 19, 2020
test/EFCore.SqlServer.FunctionalTests/Query/OwnedQuerySqlServerTest.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Mar 19, 2020
- Also add at least one additional property in each owned type. If there no columns other than shared PK then it is required dependent. - Add a property in owned type which would be sharing column for hierarchy. Currently disabled due to #20334 Resolves #20343 Resolves #20336 Finishes left over test work from #20345
smitpatel
added a commit
that referenced
this pull request
Mar 20, 2020
- Also add at least one additional property in each owned type. If there no columns other than shared PK then it is required dependent. - Add a property in owned type which would be sharing column for hierarchy. Currently disabled due to #20334 Resolves #20343 Resolves #20336 Finishes left over test work from #20345
smitpatel
added a commit
that referenced
this pull request
Mar 20, 2020
- Also add at least one additional property in each owned type. If there no columns other than shared PK then it is required dependent. - Add a property in owned type which would be sharing column for hierarchy. Currently disabled due to #20334 Resolves #20343 Resolves #20336 Finishes left over test work from #20345
This was
linked to
issues
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix involves:
Resolves #18299
Resolves #20338
Resolves #20332