Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception when saving value to a shared column #21139

Closed
AndriySvyryd opened this issue Jun 4, 2020 · 2 comments · Fixed by #22225
Closed

Exception when saving value to a shared column #21139

AndriySvyryd opened this issue Jun 4, 2020 · 2 comments · Fixed by #22225
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. regression type-bug
Milestone
5.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Jun 4, 2020 •
edited
Loading

This scenario was broken by #21128

See test in 347e9cf
AndriySvyryd added a commit that referenced this issue Jun 4, 2020
@AndriySvyryd
Test for #21139
347e9cf
@AndriySvyryd AndriySvyryd mentioned this issue Jun 4, 2020
Merged
@ajcvickers ajcvickers added this to the 5.0.0 milestone Jun 5, 2020
@ajcvickers ajcvickers self-assigned this Jul 17, 2020
@AndriySvyryd
Copy link
Member Author

Consider adding another value to ValueGenerated: OnUpdateSometimes

@ajcvickers
Copy link
Member

@AndriySvyryd @smitpatel Happy for this to be poached.

AndriySvyryd added a commit that referenced this issue Aug 25, 2020
@AndriySvyryd
Add ValueGenerated.OnUpdateSometimes for shared columns
be8a983 
Fixes #21139
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 25, 2020
@AndriySvyryd AndriySvyryd removed their assignment Aug 25, 2020
@AndriySvyryd AndriySvyryd modified the milestones: 5.0.0, 5.0.0-rc1 Aug 25, 2020
@AndriySvyryd AndriySvyryd mentioned this issue Aug 25, 2020
Merged
AndriySvyryd added a commit that referenced this issue Aug 25, 2020
@AndriySvyryd
Add ValueGenerated.OnUpdateSometimes for shared columns
a36f2e5 
Fixes #21139
AndriySvyryd added a commit that referenced this issue Aug 26, 2020
@AndriySvyryd
Add ValueGenerated.OnUpdateSometimes for shared columns
a8f16a9 
Fixes #21139
AndriySvyryd added a commit that referenced this issue Aug 26, 2020
@AndriySvyryd
Add ValueGenerated.OnUpdateSometimes for shared columns
029ad85 
Fixes #21139
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. regression type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Add ValueGenerated.OnUpdateSometimes for shared columns dotnet/efcore
3 participants
@ajcvickers @lajones @AndriySvyryd