Fix for 21041. Make all concurrency properties capable of storing "store-generated values" #21128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alues. Update TableSharingConcurrencyTokenConvention to create shadow concurrency property for all concurrency properties in the hierarchy, even non-store-generated ones.
ajcvickers
approved these changes
Jun 3, 2020
AndriySvyryd
reviewed
Jun 4, 2020
| @@ -141,8 +142,7 @@ out Dictionary<(string Table, string Schema), Dictionary<string, IList<IConventi | |||
|
|
|||
| foreach (var property in entityType.GetDeclaredProperties()) | |||
| { | |||
| if (property.IsConcurrencyToken | |||
| && (property.ValueGenerated & ValueGenerated.OnUpdate) != 0) | |||
| if (property.IsConcurrencyToken) | |||
There was a problem hiding this comment.
RelationalModelValidator needs a corresponding change
AndriySvyryd
reviewed
Jun 4, 2020
| @@ -112,7 +112,8 @@ public static bool RequiresValueGenerator([NotNull] this IProperty property) | |||
| /// </summary> | |||
| public static bool MayBeStoreGenerated([NotNull] this IProperty property) | |||
| { | |||
| if (property.ValueGenerated != ValueGenerated.Never) | |||
| if (property.ValueGenerated != ValueGenerated.Never | |||
| || property.IsConcurrencyToken) | |||
There was a problem hiding this comment.
This is not enough. Any column mapped to two or more writable properties in table sharing could also be "store-generated"
There was a problem hiding this comment.
Could you raise another issue please, with a test case that would fail?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21041.
All concurrency properties should be able to store "store-generated values". Note: in this context "store-generated values" just means "can be injected from the update pipeline".
Also updated
TableSharingConcurrencyTokenConventionto create shadow concurrency property for all concurrency properties in the hierarchy, even non-store-generated ones.