Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events aren't reset when pooled context is reset asynchronously #23108

Closed
roji opened this issue Oct 27, 2020 · 2 comments
Closed

Events aren't reset when pooled context is reset asynchronously #23108

roji opened this issue Oct 27, 2020 · 2 comments
Labels
area-dbcontext closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. Servicing-approved type-bug
Milestone
5.0.1

Comments

@roji
Copy link
Member

roji commented Oct 27, 2020

DbContext.ResetState sets the context events to null, but ResetStateAsync doesn't. Good motivation for doing #10902, assuming it's OK perf-wise.

/cc @ajcvickers (I can fix this as part of some other work in the area)
@roji roji added the type-bug label Oct 27, 2020
@roji roji self-assigned this Oct 27, 2020
@ajcvickers
Copy link
Member

🤦 Yes, fix this, but maybe on its own. We may need to patch this as well if it leads to a memory leak. (I think we should patch this in 5.0 even if it isn't a memory leak, but I still need to follow up on this with the team and then with Hunter, etc.)

roji added a commit that referenced this issue Oct 27, 2020
@roji
Reset events when Dbcontext is reset asynchronously
c7a6168 
Fixes #23108
@roji roji mentioned this issue Oct 27, 2020
Closed
@ajcvickers ajcvickers added this to the 5.0.x milestone Oct 30, 2020
@ajcvickers ajcvickers assigned ajcvickers and unassigned roji Nov 11, 2020
@ajcvickers
Copy link
Member

Poaching...

ajcvickers added a commit that referenced this issue Nov 12, 2020
@ajcvickers
Clear events when DbContext is disposed or returned to the pool
4e6c2fb 
Fixes #23108
ajcvickers added a commit that referenced this issue Nov 12, 2020
@ajcvickers
Add quirk for #23108
59c2aee
@ajcvickers ajcvickers mentioned this issue Nov 12, 2020
Merged
@ajcvickers ajcvickers modified the milestones: 5.0.x, 5.0.1 Nov 13, 2020
@ajcvickers ajcvickers added Servicing-approved closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed Servicing-consider labels Nov 13, 2020
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-dbcontext closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. Servicing-approved type-bug
Projects
None yet
Milestone
5.0.1
Development

Successfully merging a pull request may close this issue.

Reset events when DbContext is reset asynchronously dotnet/efcore
2 participants
@ajcvickers @roji