[5.0.1] Clear events when DbContext is disposed or returned to the pool #23288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23108
Description
We added three new .NET events on DbContext in 5.0. These events are not cleared when the DbContext is disposed, which can lead to memory leaks.
Customer Impact
Potential memory leak. (We had a similar bug in the early days of EF6 that resulted in several hard-to-find customer memory leaks.)
How found
Internal code review.
Test coverage
We were missing coverage for this. Added in this PR.
Regression?
No; these events are new in 5.0.
Risk
Very low. Set the event handlers to null when the context is disposed (and hence it is invalid to use it anymore and any operation on it will call ObjectDisposedException. Also quirked.