Collations aren't scaffolded correctly

[yori-s]

Scaffolding a fluent db context (using Npgsql.EntityFrameworkCore.PostgreSQL), column collations appear as HasComment rather than UseCollation.

Indexes appear to be generated with the expected collation.

RelationalScaffoldingModelFactory.VisitColumns line 500 looks a bit suspicious:

Shouldn't

            if (column.Collation != null)
            {
                property.HasComment(column.Collation);
            }

be

            if (column.Collation != null)
            {
                property.UseCollation(column.Collation);
            }

Include provider and version information

EF Core version: 5.0.0
Database provider: Npgsql.EntityFrameworkCore.PostgreSQL
Target framework: .NET 5.0
Operating system: windows 10 (docker from wsl2)
IDE: command line

[smitpatel]

cc: @roji

[roji]

Collations are actually a form of comment on the column on how to do text processing.

(JK, submitted #23388. Database collation scaffolding also doesn't work.)

[yori-s]

wow - y'all are fast 😂

[ajcvickers]

@roji Please prepare a 5.0.1 patch PR for this.

[yori-s]

Looks good using the dotnet6 feed - thanks again for the quick turnaround!

[roji]

5.0.1 patch: #23414