[5.0.1] Fix collation scaffolding #23414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23386
Description
EF Core 5.0 added support for database and column collations, but the scaffolding logic was faulty.
Customer Impact
When reverse engineering an existing database, column collations are mistakenly scaffolded as comments, and database collations aren't scaffolded at all.
How found
User-reported for 5.0.0
Test coverage
Added in this PR. In addition, we have identified scaffolding as an area where we are lacking sufficient test coverage and are beginning to address this.
Regression?
No, collations are new in 5.0.
Risk
Very low, minimal code changes, and only in the scaffolding code (no impact on runtime).