Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release/3.1] ReplacingEV uses two arrays instead of dictionary (#19858) #19867

Merged
merged 3 commits into from
Feb 14, 2020

Commits on Feb 10, 2020

  1. ReplacingEV uses two arrays instead of dictionary (#19858)

    ReplacingExpressionVisitor held original and replacement expressions
    in a dictionary. Unfortunately that means hash code calculation occurs
    exponentially, as each TryGetValue on the dictionary must traverse
    the entire tree.
    
    Replaced with two lists and a simple Equals check, which is much
    faster.
    
    Fixes #19737
    
    (cherry picked from commit 7c9fc8a)
    roji committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    b817b7e View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. Quirk mode

    roji committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    f02cd38 View commit details
    Browse the repository at this point in the history
  2. Cache quirk flag

    roji committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    acb37c2 View commit details
    Browse the repository at this point in the history