Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Convert FromSql methods to custom query roots #20154

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Query: Convert FromSql methods to custom query roots #20154

merged 2 commits into from
Mar 4, 2020

Conversation

smitpatel
Copy link
Member

  • Avoids any specific processing in core provider
  • Takes care of parameterization correctly
  • Also improved parameter extraction by creating parameter for any expression outside of lambda even when not a method call argument

Part of #20146

@smitpatel
Query: Convert FromSql methods to custom query roots
0f1dd22 
- Avoids any specific processing in core provider
- Takes care of parameterization correctly
- Also improved parameter extraction by creating parameter for any expression outside of lambda even when not a method call argument

Part of #20146
@smitpatel smitpatel mentioned this pull request Mar 4, 2020
Closed
@smitpatel smitpatel mentioned this pull request Mar 4, 2020
Closed
@smitpatel
Query: Introduce custom query root for TVF
b16b64d 
- Avoids having to do special processing in other visitors
- Visit's method's argument correctly in other visitor (this means that if there is a navigation expansion required for a parameter it will be done automatically)
- Remove Nav expansion factory not needed anymore
- Rename ExpressionPrinter.VisitList to VisitCollection and take IReadOnlyCollection, that is what most expression uses.
- Remove unnecessary exception message. They are part of a larger work item.

Resolves #20146
@smitpatel smitpatel merged commit ae392d3 into smit/queryrootpart1 Mar 4, 2020
@smitpatel smitpatel deleted the smit/queryrootpart2 branch March 4, 2020 20:54
@smitpatel smitpatel linked an issue Mar 4, 2020 that may be closed by this pull request
Query: Introduce an Expression for query root #20146
Closed
@ajcvickers ajcvickers mentioned this pull request Mar 6, 2020
Closed
@smitpatel smitpatel mentioned this pull request Mar 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@maumar maumar Awaiting requested review from maumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query: Introduce an Expression for query root
2 participants
@smitpatel @AndriySvyryd