Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Convert FromSql methods to custom query roots #20154

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Query: Convert FromSql methods to custom query roots #20154

merged 2 commits into from
Mar 4, 2020

Commits on Mar 4, 2020

  1. Query: Convert FromSql methods to custom query roots 

    - Avoids any specific processing in core provider
- Takes care of parameterization correctly
- Also improved parameter extraction by creating parameter for any expression outside of lambda even when not a method call argument

Part of #20146
    @smitpatel
    smitpatel committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    0f1dd22 View commit details
    Browse the repository at this point in the history

  2. Query: Introduce custom query root for TVF 

    - Avoids having to do special processing in other visitors
- Visit's method's argument correctly in other visitor (this means that if there is a navigation expansion required for a parameter it will be done automatically)
- Remove Nav expansion factory not needed anymore
- Rename ExpressionPrinter.VisitList to VisitCollection and take IReadOnlyCollection, that is what most expression uses.
- Remove unnecessary exception message. They are part of a larger work item.

Resolves #20146
    @smitpatel
    smitpatel committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    b16b64d View commit details
    Browse the repository at this point in the history