Query: Make CreateReadValueExpression an extension method #20321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is to read a particular index from valueBuffer for a property. It was in EntityMaterializerSource as an instance method in order for provider to influence how values are read from valueBuffer. In new query pipeline, providers are supposed to convert valueBuffer read to their database object read. Further, even if they want to create a ValueBuffer for read, the valueBuffer should have values after all custom processing. Hence there is no particular need to make this overridable behavior. Making it extension method simplify quite a lot of things. (note: functionality to use this was available anyway since the method it invoke was also publicly exposed as static.
| using JetBrains.Annotations; | ||
| using Microsoft.EntityFrameworkCore.Diagnostics; | ||
| using Microsoft.EntityFrameworkCore.Internal; | ||
| using Microsoft.EntityFrameworkCore.Metadata; | ||
| using Microsoft.EntityFrameworkCore.Query; | ||
| using Microsoft.EntityFrameworkCore.Storage; | ||
| using Microsoft.EntityFrameworkCore.Utilities; | ||
|
|
||
| namespace Microsoft.EntityFrameworkCore.Infrastructure |
There was a problem hiding this comment.
I wish this class would have been named something like InternalExpressionExtensions
There was a problem hiding this comment.
me too. Such a clash between our own code. 😢
There was a problem hiding this comment.
Technically we could rename all internal extension method classes without it being a breaking change.
There was a problem hiding this comment.
but .Infrastructure is not .Internal
AndriySvyryd
approved these changes
Mar 18, 2020
|
Is @ajcvickers happy with making this breaking change? |
…minatorCondition If DiscriminatorCondition returns null for IEntityType then return null instance. Part of #18923
ajcvickers
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is to read a particular index from valueBuffer for a property.
It was in EntityMaterializerSource as an instance method in order for provider to influence how values are read from valueBuffer.
In new query pipeline, providers are supposed to convert valueBuffer read to their database object read. Further, even if they want to create a ValueBuffer for read, the valueBuffer should have values after all custom processing.
Hence there is no particular need to make this overridable behavior. Making it extension method simplify quite a lot of things.
(note: functionality to use this was available anyway since the method it invoke was also publicly exposed as static.