Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Make CreateReadValueExpression an extension method #20321

Merged
merged 3 commits into from
Mar 18, 2020

Commits on Mar 17, 2020

  1. Query: Make CreateReadValueExpression an extension method

    This method is to read a particular index from valueBuffer for a property.
    It was in EntityMaterializerSource as an instance method in order for provider to influence how values are read from valueBuffer.
    In new query pipeline, providers are supposed to convert valueBuffer read to their database object read. Further, even if they want to create a ValueBuffer for read, the valueBuffer should have values after all custom processing.
    Hence there is no particular need to make this overridable behavior. Making it extension method simplify quite a lot of things.
    
    (note: functionality to use this was available anyway since the method it invoke was also publicly exposed as static.
    smitpatel committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    5fd8577 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Configuration menu
    Copy the full SHA
    cbe4cd5 View commit details
    Browse the repository at this point in the history
  2. Query: Make keyless entity type materialization checks part of Discri…

    …minatorCondition
    
    If DiscriminatorCondition returns null for IEntityType then return null instance.
    
    Part of #18923
    smitpatel committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    8e808f4 View commit details
    Browse the repository at this point in the history