Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Avoid potential null to bool cast #20499

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Query: Avoid potential null to bool cast #20499

merged 1 commit into from
Apr 2, 2020

Conversation

smitpatel
Copy link
Member

Resolves #20498

Manually tested in debugger. Cannot write a test since LINQ Where requires bool and does not accept bool?

@smitpatel smitpatel requested a review from a team April 2, 2020 16:34
Resolves #20498

Manually tested in debugger. Cannot write a test since LINQ Where requires bool and does not accept bool?
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you are still trying to artificially raise your commit count 😄

@smitpatel
Copy link
Member Author

@AndriySvyryd - If I had put poach-able for team, would anyone have touched that area unless asked to?

@smitpatel smitpatel merged commit cdc732f into master Apr 2, 2020
@smitpatel smitpatel deleted the smit/select branch April 2, 2020 22:25
@AndriySvyryd
Copy link
Member

You could've just included this in another PR

@smitpatel
Copy link
Member Author

Will do next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query: Trying to cast null to bool
3 participants