Fix to #15873 - Query: Identifying columns in the case of distinct #21990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Aug 7, 2020
maumar
force-pushed
the
fix15873_take2
branch
4 times, most recently
from
3658b71
to
cc7ade7
Compare
smitpatel
reviewed
Aug 11, 2020
|
@smitpatel updated |
smitpatel
reviewed
Aug 30, 2020
test/EFCore.Sqlite.FunctionalTests/Query/NorthwindGroupByQuerySqliteTest.cs
Outdated
Show resolved
Hide resolved
smitpatel
approved these changes
Aug 30, 2020
|
@Pilchie for RC1 approval. |
Added validation step for AddCollectionJoin which checks that if subquery contains Distinct or GroupBy, the projection contains all identifying columns needed to correctly bucket the results during materialization. Also making sure that identifying columns can be correctly propagated during pushdown and joining - if they are not we mark them as such (by removing identifying columns altogether), so that we can throw exception when these columns are actually needed. Fixes #15873 Fixes #20184
maumar
force-pushed
the
fix15873_take2
branch
from
205396e
to
e8d0e84
Compare
|
Approved for RC1 pending CI completion if merged before 10am Pacific on 2020-09-01. |
Pilchie
added
Servicing-approved
Servicing-consider
and removed
Servicing-consider
Servicing-approved
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation step for AddCollectionJoin which checks that if subquery contains Distinct or GroupBy, the projection contains all identifying columns needed to correctly bucket the results during materialization.
Also making sure that identifying columns can be correctly propagated during pushdown and joining - if they are not we mark them as such (by removing identifying columns altogether), so that we can throw exception when these columns are actually needed.
Fixes #15873
Fixes #20184