Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to #15873 - Query: Identifying columns in the case of distinct #21990

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Fix to #15873 - Query: Identifying columns in the case of distinct #21990

merged 1 commit into from
Sep 1, 2020

Commits on Sep 1, 2020

  1. Fix to #15873 - Query: Identifying columns in the case of distinct 

    Added validation step for AddCollectionJoin which checks that if subquery contains Distinct or GroupBy, the projection contains all identifying columns needed to correctly bucket the results during materialization.
Also making sure that identifying columns can be correctly propagated during pushdown and joining - if they are not we mark them as such (by removing identifying columns altogether), so that we can throw exception when these columns are actually needed.

Fixes #15873
Fixes #20184
    @maumar
    maumar committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    e8d0e84 View commit details
    Browse the repository at this point in the history