Be consistent about OnModelCreating as the terminology for fluent API #22343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pilchie For RC1 |
AndriySvyryd
force-pushed
the
Issue7201
branch
from
6bcc088
to
4836b04
Compare
|
Approved for RC1 pending code review signoff if merged before 10am Pacific on 2020-09-01. |
smitpatel
reviewed
Sep 1, 2020
smitpatel
reviewed
Sep 1, 2020
smitpatel
reviewed
Sep 1, 2020
smitpatel
approved these changes
Sep 1, 2020
AndriySvyryd
force-pushed
the
Issue7201
branch
from
4836b04
to
e33ea7f
Compare
|
Hello @AndriySvyryd! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Will PR checks be done in next 38 mins? 😆 |
|
Removing approval and auto-merge. Please re-add For RC1, this will require Tactics approval, or M2 approval for RC2. |
|
macOS timed out again 😢 |
|
@Pilchie For RC2 |
Use "navigation" rather than "navigation property"
Check usage of {foreignKey} and for correct quoting and use foreignKeyProperties where appropriate
Fix AnnotationNotFound, BadFilterDerivedType, CircularDependency
Update DisplayName for shared-type entity types to include the entity type name
Part of #7201
Fixes #22310
AndriySvyryd
force-pushed
the
Issue7201
branch
from
e33ea7f
to
006a113
Compare
|
Approved for RC2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "navigation" rather than "navigation property"
Check usage of {foreignKey} and for correct quoting and use foreignKeyProperties where appropriate
Fix AnnotationNotFound, BadFilterDerivedType, CircularDependency
Update DisplayName for shared-type entity types to include the entity type name
Part of #7201
Fixes #22310