[5.0] Use the schema of related ends for the join entity type by default #22845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
approved these changes
Sep 29, 2020
smitpatel
approved these changes
Sep 29, 2020
No reason not to save an additional configuration call for an explicit join entity type. |
|
@AndriySvyryd This will need to target 5.0 GA since RC2 ask mode is passed. |
AndriySvyryd
changed the title
AndriySvyryd
force-pushed
the
Issue22844
branch
from
b7b33c0
to
acc7587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22844
Description
When using the new 5.0 feature many-to-many a join entity type will be used to establish the relationship. The schema it uses currently defaults to
null, but in most scenarios it should be the same as the related entity types.Customer Impact
Since this affects a new feature fixing it after release would be a breaking change.
How found
Customer report.
Test coverage
This PR adds tests for the affected scenario.
Regression?
No
Risk
Low. The change only affects many-to-many.