Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always store join table schema in the snapshot. #26095

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Conversation

AndriySvyryd
Copy link
Member

Fixes #23937

Description

#22845 made the join entity type use the same schema as the related entity types, but it didn't persist the schema in the migration snapshot.

Customer Impact

A new migration is created even if there are no model changes.

How found

Customer report

Test coverage

Added in this PR

Regression?

No

Risk

Low, this only affects the migration snapshot, which can be fixed manually.

@AndriySvyryd AndriySvyryd requested a review from a team September 17, 2021 22:15
@AndriySvyryd
Copy link
Member Author

@Pilchie for approval

@Pilchie
Copy link
Member

Pilchie commented Sep 20, 2021

Approved for EFCore 6

@AndriySvyryd AndriySvyryd changed the title [6.0] Always store join table schema in the snapshot. Always store join table schema in the snapshot. Sep 20, 2021
@AndriySvyryd AndriySvyryd merged commit ccde2d5 into release/6.0 Sep 20, 2021
@AndriySvyryd AndriySvyryd deleted the Issue23937 branch September 20, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration loop in m:n relation with custom schema
3 participants