Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to a 6.0 SDK #22918

Merged
merged 3 commits into from
Oct 12, 2020
Merged

Upgrade to a 6.0 SDK #22918

merged 3 commits into from
Oct 12, 2020

Commits on Oct 10, 2020

  1. Upgrade to a 6.0 SDK 

    - without this, generated assemblies are unusable in aspnetcore after that brands to 6.0.0
- in other words, this is needed for dotnet/aspnetcore#24983 to test correctly
    @dougbu
    dougbu committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    2d98217 View commit details
    Browse the repository at this point in the history

  2. Check for IOException instead of missing NetworkException 

    - `NetworkException` unavailable in shared framework or a shipping package
    @dougbu
    dougbu committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    889e295 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2020

  1. Update .NET SDK version used in Helix tests 

    - eliminate need to change the .NET SDK version in two files
- `$(DotNetCliVersion)` must be set explicitly
  - Helix SDK does not pick up .NET SDK version from our global.json
- fortunately, `$(NETCoreSdkVersion)` is available in helix.proj
    @dougbu
    dougbu committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    8bbc8c4 View commit details
    Browse the repository at this point in the history