-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to a 6.0 SDK #22918
Upgrade to a 6.0 SDK #22918
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ | |
using Microsoft.EntityFrameworkCore.TestUtilities.Xunit; | ||
|
||
#if NET5_0 | ||
using System.Net; | ||
using System.IO; | ||
#endif | ||
|
||
namespace Microsoft.EntityFrameworkCore.TestUtilities | ||
|
@@ -73,7 +73,7 @@ private static bool IsNotConfigured(Exception exception) | |
{ | ||
HttpRequestException re => re.InnerException is SocketException | ||
#if NET5_0 | ||
|| (re.InnerException is NetworkException networkException | ||
|| (re.InnerException is IOException networkException | ||
&& networkException.InnerException is SocketException) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. More specifically @geoffkizer @ericstj, is this extra There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bricelam the good news here is this is a test-only change and doesn't imply a breaking change that will impact earlier EF packages when running against recent a shared framework from dotnet/runtime. |
||
#endif | ||
, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh funny, I thought we had to do a bunch of extra work to make this work. Awesome that it just works...