[5.0.1] Query: Properly generate expression to read from BufferedDataReader #23295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smitpatel Are you confident we don't need to test any other variations? |
smitpatel
changed the title
|
I enabled retrying execution strategy for whole SqlServer functional tests and ran all tests and all passed (except obvious wrong ones in the tests which tests retrying strategy). Further looking at blame (which is on me), it was incorrect refactor and this code is pretty close to what 3.1 did. So I am quite confident. |
|
Thanks @smitpatel. Makes sense. |
AndriySvyryd
approved these changes
Nov 13, 2020
maumar
approved these changes
Nov 13, 2020
ajcvickers
added
Servicing-approved
and removed
Servicing-consider
sent-to-tactics
labels
|
Approved by Tactics for 5.0.1 |
Resolves #23282 Resolves #23104 Issue: When buffering is enabled, first time when we read particular property slot, we create expression to read into buffer and out of the buffer. We mistakenly bypassed changing expression to read from value buffer when same property slot was being read again, causing cast errors Also matches the type being read out of the buffered data reader
smitpatel
force-pushed
the
smit/AnTeeAs
branch
from
2033f65
to
fad3c60
Compare
|
smitpatelsmitpatel is it possible to add the same fox for v.3.1.7? Initially bug was reported for this version (efcore/EFCore.SqlServer.HierarchyId#24) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #23282
Resolves #23104
Issue: When buffering is enabled, first time when we read particular property slot, we create expression to read into buffer and out of the buffer. We mistakenly bypassed changing expression to read from value buffer when same property slot was being read again, causing cast errors.
Description
Any type mapping having custom read expression from data reader throws an exception while retrying strategy is enabled. This was reported for SQL Server spatial types, but we know that Oracle uses the same pattern for some of its type mappings, so this is likely to be broken for Oracle too once they have an updated provider.
Customer Impact
When retrying strategy is enabled (which is recommended for all SQL Azure applications), querying for spatial types or any other non-primitive type will hit an exception.
How found
Customer reported on 5.0.
Test coverage
Added test for affected scenario.
Regression?
Yes, this worked in 3.1.
Risk
Low. This reverts back to 3.1 behavior in terms of generating correct expression.