Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0.1] Query: Properly generate expression to read from BufferedDataReader #23295

Merged
merged 1 commit into from
Nov 17, 2020
Merged

[5.0.1] Query: Properly generate expression to read from BufferedDataReader #23295

merged 1 commit into from
Nov 17, 2020

Commits on Nov 17, 2020

  1. Query: Properly generate expression to read from BufferedDataReader 

    Resolves #23282
Resolves #23104

Issue:
When buffering is enabled, first time when we read particular property slot, we create expression to read into buffer and out of the buffer.
We mistakenly bypassed changing expression to read from value buffer when same property slot was being read again, causing cast errors
Also matches the type being read out of the buffered data reader
    @smitpatel
    smitpatel committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    fad3c60 View commit details
    Browse the repository at this point in the history