Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: SVE - Add FFR lifetime tracking as well as test coverage for NonFaulting APIs #105163

Closed
TIHan opened this issue Jul 19, 2024 · 4 comments · Fixed by #106648
Closed

JIT: SVE - Add FFR lifetime tracking as well as test coverage for NonFaulting APIs #105163

TIHan opened this issue Jul 19, 2024 · 4 comments · Fixed by #106648
Assignees
@SwapnilGaikwad
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged Priority:2 Work that is important, but not critical for the release
Milestone
9.0.0

Comments

@TIHan
Copy link
Contributor

TIHan commented Jul 19, 2024

Since we have already merged the NonFaulting SVE APIs, we need to add additional testing on their first-faulting behavior since they share the similar behavior as the FirstFaulting APIs. See #104502
@TIHan TIHan added this to the 9.0.0 milestone Jul 19, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 19, 2024
@TIHan TIHan changed the title JIT: SVE Cleanup - Added first-faulting behavior testing for NonFaulting APIs JIT: SVE - Added first-faulting behavior testing for NonFaulting APIs Jul 19, 2024
@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 23, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@JulieLeeMSFT JulieLeeMSFT added arm-sve Work related to arm64 SVE/SVE2 support and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 24, 2024
@a74nh
Copy link
Contributor

a74nh commented Jul 30, 2024

priority:2 for RC1 snap : Missing testing

@a74nh a74nh added the Priority:2 Work that is important, but not critical for the release label Jul 30, 2024
@JulieLeeMSFT
Copy link
Member

@mikabl-arm, PTAL.

@kunalspathak
Copy link
Member

Note: This is not just test coverage, but we need to also model FFR register lifetime for non-faulting APIs. So this also needs product change.

@kunalspathak kunalspathak changed the title JIT: SVE - Added first-faulting behavior testing for NonFaulting APIs JIT: SVE - Add FFR lifetime tracking as well as test coverage for NonFaulting APIs Aug 14, 2024
SwapnilGaikwad added a commit to SwapnilGaikwad/runtime that referenced this issue Aug 19, 2024
@SwapnilGaikwad
Add Non-Faulting behaviour for Sve.LoadVector*NonFaulting*()
0fd6941 
Fixes: dotnet#105163
@SwapnilGaikwad SwapnilGaikwad mentioned this issue Aug 19, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 19, 2024
github-actions bot pushed a commit that referenced this issue Aug 21, 2024
@SwapnilGaikwad
Add Non-Faulting behaviour for Sve.LoadVector*NonFaulting*()
d035464 
Fixes: #105163
jeffschwMSFT added a commit that referenced this issue Aug 22, 2024
@github-actions @SwapnilGaikwad
@amanasifkhalid @jeffschwMSFT
[release/9.0] Add Non-Faulting behaviour for Sve.LoadVector*NonFaulti…
7384dc4 
…ng*() (#106768)

* Add Non-Faulting behaviour for Sve.LoadVector*NonFaulting*()

Fixes: #105163

* Fix typo

---------

Co-authored-by: Swapnil Gaikwad <swapnil.gaikwad@arm.com>
Co-authored-by: Aman Khalid <amankhalid@microsoft.com>
Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SwapnilGaikwad SwapnilGaikwad

Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged Priority:2 Work that is important, but not critical for the release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Add Non-Faulting behaviour for Sve.LoadVector*NonFaulting*() SwapnilGaikwad/runtime
6 participants
@TIHan @a74nh @SwapnilGaikwad @jeffschwMSFT @kunalspathak @JulieLeeMSFT