Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VS install requirements to bump Windows 10 SDK version #100170

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

jeffhandley
Copy link
Member

As was discovered in #94106, our build now requires Windows 10 SDK 10.0.20348+. Using version 10.0.19041 results in the following build error when building mono.

C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\winbase.h(9531): error C2220: the following warning is treated as an error
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\winbase.h(9531): warning C5105: macro expansion producing 'defined' has undefined behavior

I stumbled upon this while building clr+mono on a fresh machine. Updating the Windows 10 SDK version fixed my build.

@jeffhandley jeffhandley added this to the 9.0.0 milestone Mar 23, 2024
@jeffhandley jeffhandley self-assigned this Mar 23, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Comment on lines 39 to 40
* **Desktop Development with C++** with all default components, plus:
* *Windows 10 SDK (10.0.20348)* or newer, instead of version 10.0.19041
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Desktop Development with C++** with all default components, plus:
* *Windows 10 SDK (10.0.20348)* or newer, instead of version 10.0.19041
* **Desktop Development with C++** with all default components.

This should not be necessary. I do not think that Desktop Development with C++ in Visual Studio 2022 17.8+ installs this several years old SDK by default. The SDK installed by Visual Studio 2022 17.8+ should be new enough for us. (I am not able check 17.8, but the default in 17.9 that I am on is 10.0.22621.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if my machine was picking up some old artifact then. I removed all VS installs from my machine and then chose to reinstall VS 2022 Preview and version 10.0.19041 was checked and the others weren't. I'll revert the changes to that file and keep just the change to .vsconfig.

Thanks.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit f100da5 into dotnet:main Mar 25, 2024
11 of 120 checks passed
@jeffhandley jeffhandley deleted the jeffhandley/windows-requirements branch March 26, 2024 00:15
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants