Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VS install requirements to bump Windows 10 SDK version #100170

Merged
merged 2 commits into from
Mar 25, 2024
+1 −1
Merged

Update VS install requirements to bump Windows 10 SDK version #100170

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d64912
Update VS install requirements to bump Windows 10 SDK version
jeffhandley Mar 23, 2024
c3b9a6b
Revert changes to windows-requirements.md per review feedback
jeffhandley Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vsconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"Microsoft.VisualStudio.Component.VC.Redist.14.Latest",
"Microsoft.VisualStudio.Component.VC.Tools.ARM64",
"Microsoft.VisualStudio.Component.VC.Tools.x86.x64",
"Microsoft.VisualStudio.Component.Windows10SDK.19041",
"Microsoft.VisualStudio.Component.Windows10SDK.20348",
"Microsoft.VisualStudio.ComponentGroup.MSIX.Packaging",
"Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Core",
"Microsoft.VisualStudio.Workload.CoreEditor",
Expand Down
3 changes: 2 additions & 1 deletion docs/workflow/requirements/windows-requirements.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ Note that Visual Studio and the development tools described below are required,

* It's recommended to use **Workloads** installation approach. The following are the minimum requirements:
* **.NET Desktop Development** with all default components,
* **Desktop Development with C++** with all default components.
* **Desktop Development with C++** with all default components, plus:
* *Windows 10 SDK (10.0.20348)* or newer, instead of version 10.0.19041
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Desktop Development with C++** with all default components, plus:
* *Windows 10 SDK (10.0.20348)* or newer, instead of version 10.0.19041
* **Desktop Development with C++** with all default components.

This should not be necessary. I do not think that Desktop Development with C++ in Visual Studio 2022 17.8+ installs this several years old SDK by default. The SDK installed by Visual Studio 2022 17.8+ should be new enough for us. (I am not able check 17.8, but the default in 17.9 that I am on is 10.0.22621.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if my machine was picking up some old artifact then. I removed all VS installs from my machine and then chose to reinstall VS 2022 Preview and version 10.0.19041 was checked and the others weren't. I'll revert the changes to that file and keep just the change to .vsconfig.

Thanks.

* To build for Arm64, make sure that you have the right architecture-specific compilers installed. In the **Individual components** window, in the **Compilers, build tools, and runtimes** section:
* For Arm64, check the box for _MSVC v143* VS 2022 C++ ARM64 build tools (Latest)_.
* To build the tests, you will need some additional components:
Expand Down
Loading