[tvOS] Make the managed code depending on System.Net.Security.Native throw PNSE #51861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximLipnin
requested review from
mdh1418,
steveisok,
filipnavara,
marek-safar and
akoeplinger
filipnavara
reviewed
Apr 26, 2021
There was a problem hiding this comment.
The interop files for P/Invoke still need to be removed from the build (.csproj). Otherwise the Xamarin tooling will see them unless a Linker is enabled.
Not sure what is the file name convention for the PNSE files. Some pre-existing sources use the .PlatformNotSupported.cs suffix which is what I ended up using in my (not yet reviewed/approved) PRs.
MaximLipnin
force-pushed
the
make_snsn_throw_pnse_on_tvos
branch
from
f8a7bb9
to
8672941
Compare
marek-safar
reviewed
Apr 27, 2021
src/libraries/Common/src/Microsoft/Win32/SafeHandles/GssSafeHandles.PlatformNotSupported.cs
Show resolved
Hide resolved
MaximLipnin
force-pushed
the
make_snsn_throw_pnse_on_tvos
branch
from
cb61096
to
7d9a449
Compare
MaximLipnin
changed the title
filipnavara
reviewed
Apr 28, 2021
src/libraries/Common/src/Microsoft/Win32/SafeHandles/GssSafeHandles.PlatformNotSupported.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Microsoft/Win32/SafeHandles/GssSafeHandles.PlatformNotSupported.cs
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Apr 28, 2021
src/libraries/System.Net.Security/src/System.Net.Security.csproj
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Apr 28, 2021
...aries/System.Net.Security/src/System/Net/Security/NegotiateStreamPal.PlatformNotSupported.cs
Show resolved
Hide resolved
marek-safar
reviewed
Apr 28, 2021
src/libraries/Common/src/System/Net/Security/NegotiateStreamPal.PlatformNotSupported.cs
Show resolved
Hide resolved
marek-safar
approved these changes
Apr 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#45535