Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tvOS] System.Net.Security depends on non-existant System.Net.Security.Native #45535

Closed
filipnavara opened this issue Dec 3, 2020 · 5 comments
Closed

[tvOS] System.Net.Security depends on non-existant System.Net.Security.Native #45535

filipnavara opened this issue Dec 3, 2020 · 5 comments
Assignees
@steveisok @MaximLipnin
Labels
area-System.Net.Security os-tvos Apple tvOS
Milestone
6.0.0

Comments

@filipnavara
Copy link
Member

filipnavara commented Dec 3, 2020 •
edited
Loading

There's no GSS support on tvOS and hence System.Net.Security.Native is not built on the platform (

runtime/src/libraries/Native/Unix/CMakeLists.txt

Line 224 in 3c39a5d

#add_subdirectory(System.Net.Security.Native) # no gssapi on tvOS, see https://developer.apple.com/documentation/gss
). The managed code still references the library though which causes problem when trying to link on the platform. I assume it should throw PNSE instead.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Net.Security untriaged New issue has not been triaged by the area owner labels Dec 3, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

There's no GSS support on tvOS and hence System.Net.Security.Native is not built on the platform (

runtime/src/libraries/Native/Unix/CMakeLists.txt

Line 224 in 3c39a5d

#add_subdirectory(System.Net.Security.Native) # no gssapi on tvOS, see https://developer.apple.com/documentation/gss
). The managed code still references the library though which causes problem when trying to link on the platform. I assume it should throw PSNE instead.

Author: filipnavara
Assignees: -
Labels:

area-System.Net.Security, untriaged
Milestone: -

@filipnavara filipnavara mentioned this issue Dec 3, 2020
Merged
@rolfbjarne rolfbjarne mentioned this issue Dec 3, 2020
Closed
61 tasks
@steveisok
Copy link
Member

Yes, we'll need to throw PNSE.

@steveisok steveisok removed the untriaged New issue has not been triaged by the area owner label Dec 3, 2020
@steveisok steveisok added this to the 6.0.0 milestone Dec 3, 2020
@steveisok steveisok self-assigned this Dec 3, 2020
@steveisok steveisok added os-ios Apple iOS os-tvos Apple tvOS and removed os-ios Apple iOS labels Dec 3, 2020
@steveisok steveisok mentioned this issue Apr 1, 2021
Closed
@MaximLipnin
Copy link
Contributor

Am I right that the whole Interop.NetSecurityNative.cs should throw PNSE?

@filipnavara
Copy link
Member Author

It would be the whole directory containing that file. However, it probably makes more sense to avoid using that code altogether and just make a version of NegotiateStreamPal (and ContextFlagsAdapterPal and Capability.Security.Unix.cs) that throws PNSE early on.

@MaximLipnin MaximLipnin mentioned this issue Apr 26, 2021
Merged
@MaximLipnin
Copy link
Contributor

It's addressed in #51861.

@ghost ghost locked as resolved and limited conversation to collaborators May 29, 2021
vs-mobiletools-engineering-service2 pushed a commit to xamarin/xamarin-macios that referenced this issue Jul 30, 2021
@rolfbjarne
[tools] Revert workaround for dotnet/runtime#45535. (#12011)
7c042c9 
The dotnet/runtime issue in question has been fixed.

Ref: dotnet/runtime#45535
Ref: 39948aa
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@steveisok steveisok

@MaximLipnin MaximLipnin

Labels
area-System.Net.Security os-tvos Apple tvOS
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
4 participants
@steveisok @filipnavara @MaximLipnin @Dotnet-GitSync-Bot