Skip to content

Commit

Permalink
[tools] Revert workaround for dotnet/runtime#45535. (#12011)
Browse files Browse the repository at this point in the history 
The dotnet/runtime issue in question has been fixed.

Ref: dotnet/runtime#45535
Ref: 39948aa
  • Loading branch information
@rolfbjarne
rolfbjarne committed Jul 30, 2021
1 parent 6dfdcf8 commit 7c042c9
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions tools/linker/MonoTouch.Tuner/ListExportedSymbols.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,6 @@ void ProcessMethod (MethodDefinition method)

case "libSystem.Net.Security.Native":
case "System.Net.Security.Native":
#if NET
// tvOS does not ship with System.Net.Security.Native due to https://github.com/dotnet/runtime/issues/45535
if (DerivedLinkContext.App.Platform == ApplePlatform.TVOS) {
Driver.Log (4, "Did not add native reference to {0} in {1} referenced by {2} in {3}.", pinfo.EntryPoint, pinfo.Module.Name, method.FullName, method.Module.Name);
break;
}
#endif
addPInvokeSymbol = true;
break;

Expand Down

6 comments on commit 7c042c9

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)

Packages generated

View packages

Test results

2 tests failed, 222 tests passed.

Failed tests

  • monotouch-test/iOS Unified 32-bits - simulator/Debug: Failed
  • Documentation/All: Failed

Pipeline on Agent XAMBOT-1025.BigSur'
[tools] Revert workaround for dotnet/runtime#45535. (#12011)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[tools] Revert workaround for dotnet/runtime#45535. (#12011)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests tvOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[tools] Revert workaround for dotnet/runtime#45535. (#12011)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on macOS M1 - Mac Big Sur (11.5) ❌

Tests failed on M1 - Mac Big Sur (11.5).

Failed tests are:

  • xammac_tests

Pipeline on Agent
[tools] Revert workaround for dotnet/runtime#45535. (#12011)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac Mojave (10.14) ✅

Tests passed

All tests on macOS X Mac Mojave (10.14) passed.

Pipeline on Agent
[tools] Revert workaround for dotnet/runtime#45535. (#12011)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac High Sierra (10.13) ✅

Tests passed

All tests on macOS X Mac High Sierra (10.13) passed.

Pipeline on Agent
[tools] Revert workaround for dotnet/runtime#45535. (#12011)

Please sign in to comment.