add AcceptAsync cancellation overloads #53340
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsContributes to #33418 Add overloads to Socket.AcceptAsync that take a CancellationToken, and wire up support for cancellation. AcceptAsync now uses the ValueTask-based mapping to SocketAsyncEventArgs (it previously used the Task-based mapping). Optimize AcceptAsync for synchronous completion by deferring pinning of the accept buffer. Minor SendFileAsync test cleanup from recent SendFileAsync PR.
|
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Nice. Generally looks good.
I was going to ask that you also fix #40289, but I see that CI flagged it anyway due to there now being a CancellationToken-based overload, and our analyzer that flags not correctly passing the token around kicking in.
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
#40289 is now fixed, including enabling the relevant test on Unix. I also added the corresponding TcpListener overloads. PTAL. |
…asm_debugger_and_use_debugger_agent * upstream/main: (597 commits) Fix42292 (dotnet#52463) [mono] Remove some obsolete emscripten flags. (dotnet#53486) Fixed path to projects (dotnet#53435) support ServerCertificateContext in quic (dotnet#53175) Socket: delete unix local endpoint filename on Close (dotnet#52103) [mono] Fix sgen_gc_info.memory_load_bytes (dotnet#53364) Refactor MsQuic's native IP address types. (dotnet#53461) Re-enabled optimizations for gtFoldExprConst (dotnet#53347) Add diagnostic support into sample app and AppBuilders on Mono. (dotnet#53361) Fix issues with virtuals and mdarrays (dotnet#53400) Split Variant marshalling tests (dotnet#53035) Update clrjit.natvis to cover GT_SIMD and GT_HWINTRINSIC (dotnet#53470) remove WSL checks in tests (dotnet#53475) Always spawn message loop thread for SystemEvents (dotnet#53467) add AcceptAsync cancellation overloads (dotnet#53340) Remove unnecessary reference to iOS workload pack in the Mono workload (dotnet#53425) Add CookieContainer.GetAllCookies (dotnet#53441) Remove DynamicallyAccessedMembers on JsonSerializer (dotnet#53235) [wasm] Re-enable Wasm.Build.Tests (dotnet#53433) [libraries] Move library tests Feature Switches defaults to Functional tests (dotnet#53253) ...
ghost
locked as resolved and limited conversation to collaborators
Contributes to #33418
Fixes #40289
Add overloads to Socket.AcceptAsync that take a CancellationToken, and wire up support for cancellation.
AcceptAsync now uses the ValueTask-based mapping to SocketAsyncEventArgs (it previously used the Task-based mapping).
Optimize AcceptAsync for synchronous completion by deferring pinning of the accept buffer.
Minor SendFileAsync test cleanup from recent SendFileAsync PR.
Add similar overloads for TcpListener.
Fix the Unix implementation of named pipe servers to wire up cancellation via this new overload.