Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove WSL checks in Socket tests #53475

Merged
merged 1 commit into from
May 30, 2021
Merged

remove WSL checks in Socket tests #53475

merged 1 commit into from
May 30, 2021

Conversation

geoffkizer
Copy link
Contributor

Contributes to #18258

@ViktorHofer @tarekgh

@ghost
Copy link

ghost commented May 30, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #18258

@ViktorHofer @tarekgh

Author: geoffkizer
Assignees: -
Labels:

area-System.Net.Sockets
Milestone: -

stephentoub
stephentoub approved these changes May 30, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests now work on WSL?

Or the failures were with WSL1 and they work fine with WSL2?

@ViktorHofer ViktorHofer merged commit 11dc7d4 into dotnet:main May 30, 2021
@geoffkizer
Copy link
Contributor Author

Or the failures were with WSL1 and they work fine with WSL2?

Yes

@geoffkizer geoffkizer deleted the removewsltestchecks branch May 30, 2021 12:15
@ManickaP
Copy link
Member

ManickaP commented May 31, 2021 •
edited
Loading

AFAIR the WSL2 shows up as a regular Linux OS, so the conditional attribute and check for IsNotWindowsSubsystemForLinux were specifically for WSL 1.
If the tests work for WSL 1 then great, if not we should probably keep the attribute.
Note that the tests should have been run on WSL2 even with the condition.
However, something might have changed since the last time I checked this, so my info might be outdated.

@ViktorHofer
Copy link
Member

If the tests work for WSL 1 then great, if not we should probably keep the attribute.

As already mentioned in another thread, we shouldn't support WSL1 in dotnet/runtime at all anymore.

thaystg added a commit to thaystg/runtime that referenced this pull request Jun 1, 2021
@thaystg
Merge remote-tracking branch 'upstream/main' into thays_remove_mini_w…
c4bf8fc 
…asm_debugger_and_use_debugger_agent

* upstream/main: (597 commits)
  Fix42292 (dotnet#52463)
  [mono] Remove some obsolete emscripten flags. (dotnet#53486)
  Fixed path to projects (dotnet#53435)
  support ServerCertificateContext in quic (dotnet#53175)
  Socket: delete unix local endpoint filename on Close (dotnet#52103)
  [mono] Fix sgen_gc_info.memory_load_bytes (dotnet#53364)
  Refactor MsQuic's native IP address types. (dotnet#53461)
  Re-enabled optimizations for gtFoldExprConst (dotnet#53347)
  Add diagnostic support into sample app and AppBuilders on Mono. (dotnet#53361)
  Fix issues with virtuals and mdarrays (dotnet#53400)
  Split Variant marshalling tests (dotnet#53035)
  Update clrjit.natvis to cover GT_SIMD and GT_HWINTRINSIC (dotnet#53470)
  remove WSL checks in tests (dotnet#53475)
  Always spawn message loop thread for SystemEvents (dotnet#53467)
  add AcceptAsync cancellation overloads (dotnet#53340)
  Remove unnecessary reference to iOS workload pack in the Mono workload (dotnet#53425)
  Add CookieContainer.GetAllCookies (dotnet#53441)
  Remove DynamicallyAccessedMembers on JsonSerializer  (dotnet#53235)
  [wasm] Re-enable Wasm.Build.Tests (dotnet#53433)
  [libraries] Move library tests Feature Switches defaults to Functional tests (dotnet#53253)
  ...
@ghost ghost locked as resolved and limited conversation to collaborators Jun 30, 2021
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
area-System.Net.Sockets
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@geoffkizer @ManickaP @ViktorHofer @stephentoub @karelz