[wasm] Switch default modules to es6 #62740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
NO-REVIEW
pavelsavara
requested review from
radical,
lewing,
kg,
radekdoulik,
thaystg and
maraf
pavelsavara
force-pushed
the
wasm_switch_to_es6
branch
2 times, most recently
from
4ac6c57
to
b1bf9e1
Compare
pavelsavara
force-pushed
the
wasm_switch_to_es6
branch
from
b1bf9e1
to
4595b3b
Compare
pavelsavara
force-pushed
the
wasm_switch_to_es6
branch
from
4595b3b
to
82961c8
Compare
pavelsavara
force-pushed
the
wasm_switch_to_es6
branch
from
82961c8
to
8590b3c
Compare
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
force-pushed
the
wasm_switch_to_es6
branch
2 times, most recently
from
ac777b2
to
dd675ef
Compare
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
force-pushed
the
wasm_switch_to_es6
branch
from
873fb97
to
7635ed5
Compare
pavelsavara
changed the title
|
/azp run runtime-manual |
maraf
force-pushed
the
wasm_switch_to_es6
branch
from
1e7b2a0
to
fb042f2
Compare
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit 25ee613.
# Conflicts: # src/mono/wasm/runtime/CMakeLists.txt # src/mono/wasm/wasm.proj
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
# Conflicts: # src/mono/wasm/test-main.js
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 7, 2022
Closed
|
Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it. |
ghost
closed this
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation, benefits
Challenges, downsides
Changes in this PR
<WasmEnableES6>default trueEXPORT_ES6=1should not be in theemcc-link.rspbecause it could not be removed by workload re-link when<WasmEnableES6> == false.