Add retries to ModulesAreDisposedWhenProcessIsDisposed #68104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process Issue DetailsFix #68035 It seems that EnumProcessModules is prone to returning ERROR_PARTIAL_COPY when invoked on a process that is in the process of starting (in some terms). We already have 50ms of retries inside the product for this; possibly that should be more retries, and only for ERROR_PARTIAL_COPY. However I'm reluctant to to modify that without more evidence. Meantime, just adding retries to this one test that calls it immediately after starting a process.
|
|
Failure is the indomitable #67349 |
adamsitnik
approved these changes
Apr 20, 2022
src/libraries/System.Diagnostics.Process/tests/ProcessModuleTests.cs
Outdated
Show resolved
Hide resolved
…sts.cs Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
|
failures are #68293 |
directhex
pushed a commit
to directhex/runtime
that referenced
this pull request
Apr 21, 2022
* Add retries to ModulesAreDisposedWhenProcessIsDisposed * Update src/libraries/System.Diagnostics.Process/tests/ProcessModuleTests.cs Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com> Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #68035
It seems that EnumProcessModules is prone to returning ERROR_PARTIAL_COPY when invoked on a process that is in the process of starting (in some terms). We already have 50ms of retries inside the product for this; possibly that should be more retries, and only for ERROR_PARTIAL_COPY. However I'm reluctant to to modify that without more evidence. Meantime, just adding retries to this one test that calls it immediately after starting a process.