System.IO.Compression.Tests.ZipFile_Unix.UnixCreateSetsPermissionsInExternalAttributes fail on OSX #68293
Comments
dotnet-issue-labeler
bot
added
area-System.IO.Compression
untriaged
|
Tagging subscribers to this area: @dotnet/area-system-io-compression Issue DetailsRunfo Creating Tracking Issue (data being generated)
|
|
The earliest build listed above was 4/20/2022, 11:00:15 AM. I checked in my zip bug fix (not that I can see how it was related) at ~12 PST. |
|
Expected: 3968 -> 7600, which is Lots of hits today. Marking as blocking-clean-ci. |
elinor-fung
added
the
blocking-clean-ci
|
@dotnet/dnceng did anything change in the OSX 12 image? @eerhardt you recall this code -- any idea? this line may be relevant, but it suggests that we should expect these bits to be cleared? |
Hi Dan! Can you comment on time? The only interesting thing to change here was moving from 12.0 to 12.3 a while back because the GA 12.0 kept timing out. That wasn't particularly recently though, so your time range would be useful to know. |
|
@danmoseley I confirmed the update (12.0 -> 12.3 latest-at-the-time) was on 3/29, about 3 weeks ago. Beyond this, these machines have done nothing but execute test work items. |
|
@eerhardt thoughts? does this pass on your mac hardware (I assume it's 12.3 or you can update it) |
|
oh, he's out til Monday. I'll disable the test meantime (I should have done this already) |
danmoseley
added
disabled-test
|
Also affecting the When this issue gets fixed, the fix needs to get backported to |
…pple OSes There are scenarios where chmod succeeds, but the OS clears certain bits, like S_ISGID and S_ISUID. When this happens, the ZipFile tests fail because the .zip file doesn't contain the expected ExternalAttributes. To fix this, read the file mode after calling chmod, and update the expected file mode so the tests still pass. Fix dotnet#68293 Fix dotnet#60581
ghost
added
the
in-pr
|
I finally got back to this. I've created #69583 to fix this issue. The problem, as far as I can tell, is that the macOS devices used in CI must have changed which group they run under, or somehow the user configuration on the machines changed. The tests were failing because they expected the
So, what was happening here is that the test was calling |
|
Thanks for the investigation, @eerhardt. Coincidentally, I still have to fix a bug in the tar tests related to chmod to make sure it is working properly, and after the fix I need to make sure they don't hit the same failure. |
…pple OSes (#69583) * ZipFile UnixCreateSetsPermissionsInExternalAttributes test fails on Apple OSes There are scenarios where chmod succeeds, but the OS clears certain bits, like S_ISGID and S_ISUID. When this happens, the ZipFile tests fail because the .zip file doesn't contain the expected ExternalAttributes. To fix this, read the file mode after calling chmod, and update the expected file mode so the tests still pass. Fix #68293 Fix #60581 * Fix the tests to expect the correct file name
ghost
removed
the
in-pr
ghost
locked as resolved and limited conversation to collaborators
Runfo Tracking Issue: System.IO.Compression.Tests.ZipFile_Unix.UnixCreateSetsPermissionsInExternalAttributes fail on OSX
Build Result Summary
The text was updated successfully, but these errors were encountered: