Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TestEventListener #68273

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Added TestEventListener #68273

merged 2 commits into from
Apr 21, 2022

Conversation

ManickaP
Copy link
Member

Allows logging of specific event sources into test output. Useful for test debugging. Usage:

private TestEventListener _listener;

public MsQuicQuicStreamConformanceTests(ITestOutputHelper output)
{
    _output = output;
    _listener = new TestEventListener(_output, "Private.InternalDiagnostics.System.Net.Quic");
}
protected override void Dispose(bool disposing)
{
    _listener.Dispose();
    base.Dispose(disposing);
}

@ghost ghost assigned ManickaP Apr 20, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ManickaP ManickaP requested a review from a team April 20, 2022 16:08
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
It may be with off adding at least some hook as example.
We have other places (DOTNET_TEST_NET_SECURITY_FORCE_SOCKET_STREAMS & DOTNET_TEST_HTTP2_FORCEUNENCRYPTEDLOOPBACK) where hooks like this are enable via environmental variables.

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ManickaP ManickaP merged commit d471409 into dotnet:main Apr 21, 2022
@ManickaP ManickaP deleted the mapichov/test_output branch April 21, 2022 13:47
@ghost ghost locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants