New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Ensure prerequisites are installed on the perf pipeline #72431

Merged

radical merged 1 commit into dotnet:main from radical:perf-prereqs

Aug 5, 2022

Member

radical commented Jul 19, 2022

No description provided.

radical added arch-wasm area-Infrastructure-mono labels

ghost assigned radical

Member Author

radical commented Jul 19, 2022

/azp run perf-wasm

ghost commented Jul 19, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	radical
Assignees:	-
Labels:	`arch-wasm`, `area-Infrastructure-mono`
Milestone:	-

azure-pipelines bot commented Jul 19, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

radical commented Jul 19, 2022

/azp run perf-wasm

azure-pipelines bot commented Jul 19, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

radical commented Jul 19, 2022

/azp run perf-wasm

azure-pipelines bot commented Jul 19, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

radical commented Jul 19, 2022

/azp run perf-wasm

azure-pipelines bot commented Jul 19, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

radical commented Jul 19, 2022

/azp run perf-wasm

azure-pipelines bot commented Jul 19, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

radical commented Jul 19, 2022

/azp run perf-wasm

azure-pipelines bot commented Jul 19, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

radical commented Jul 19, 2022

/azp run perf-wasm

azure-pipelines bot commented Jul 19, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

radical commented Jul 20, 2022

/azp run perf-wasm

azure-pipelines bot commented Jul 20, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

radical commented Jul 23, 2022

/azp run perf-wasm

azure-pipelines bot commented Jul 23, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

radical commented Jul 24, 2022

/azp run perf-wasm

azure-pipelines bot commented Jul 24, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

radical commented Jul 24, 2022

/azp run perf-wasm

azure-pipelines bot commented Jul 24, 2022

Azure Pipelines successfully started running 1 pipeline(s).

radical force-pushed the perf-prereqs branch from 92481c8 to dbc99ae Compare

July 28, 2022 06:02


          [wasm][perf] Update prerequistes, and fail if they cannot be installed

62b1136

- this updates node/npm to 18.x
- And passes `--not-in-lab` for PRs builds, so it doesn't try to setup
  access tokens.

radical force-pushed the perf-prereqs branch from dbc99ae to 62b1136 Compare

August 1, 2022 21:11

radical requested a review from lewing

August 1, 2022 21:14

radical requested review from LoopedBard3, DrewScoggins, adamsitnik and akoeplinger

August 1, 2022 21:14

radical marked this pull request as ready for review

August 1, 2022 21:14

Member Author

radical commented Aug 1, 2022

/azp run runtime-wasm-perf

azure-pipelines bot commented Aug 1, 2022

Azure Pipelines successfully started running 1 pipeline(s).

radical mentioned this pull request

runtime-wasm-perf: add support for running against forks, and branches #73105

Merged

adamsitnik approved these changes

View reviewed changes

Member

adamsitnik left a comment

LGTM, thank you @radical !

eng/pipelines/coreclr/templates/run-performance-job.yml

+                      $HELIX_WORKITEM_PAYLOAD/bin/jsvu --os=linux64 --engines=v8,javascriptcore &&
+                      export PERFLAB_UPLOAD_TOKEN="$(HelixPerfUploadTokenValue)" &&
+                      export PERF_PREREQS_INSTALLED=1;
+                      test "x$PERF_PREREQS_INSTALLED" = "x1" || echo "** Error: Failed to install prerequites **"

Member

adamsitnik Aug 5, 2022

we should consider moving this logic to an .sh file

radical merged commit fe957c0 into dotnet:main

radical deleted the perf-prereqs branch

August 5, 2022 23:40

Member

LoopedBard3 commented Aug 8, 2022

@radical it appears that this is creating errors on windows micro builds: https://dev.azure.com/dnceng/internal/_build/results?buildId=1929747&view=results. Specifically: '"x$PERF_PREREQS_INSTALLED" was unexpected at this time.'. I think this is due to windows builds not supporting the bash-style if statements (could be wrong on this). I noticed that the prereqs envvar was not added to the windows precommands, would duplicating the command without the if statement and conditioning based on if we are on Windows_NT (like Condition="'$(AGENT_OS)' != 'Windows_NT'") work with these changes as expected?

Member Author

radical commented Aug 8, 2022

Yes, adding Condition="'$(AGENT_OS)' != 'Windows_NT'" so the command is added only for !windows, would work.

Member Author

radical commented Aug 8, 2022

Yes, adding Condition="'$(AGENT_OS)' != 'Windows_NT'" so the command is added only for !windows, would work.

Are you opening a PR, or should I?

Member

LoopedBard3 commented Aug 8, 2022

I can open a PR. 👍

LoopedBard3 mentioned this pull request

[PERF] Fix "x$PERF_PREREQS_INSTALLED was unexpected at this time" Error for Microbenchmarks #73584

Merged

ghost locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

adamsitnik adamsitnik approved these changes

lewing Awaiting requested review from lewing

LoopedBard3 Awaiting requested review from LoopedBard3

DrewScoggins Awaiting requested review from DrewScoggins

akoeplinger Awaiting requested review from akoeplinger

Labels

arch-wasm area-Infrastructure-mono