Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime-wasm-perf: add support for running against forks, and branches #73105

Merged
merged 1 commit into from
Aug 5, 2022
Merged

runtime-wasm-perf: add support for running against forks, and branches #73105

merged 1 commit into from
Aug 5, 2022

Conversation

radical
Copy link
Member

@radical radical commented Jul 30, 2022 •
edited
Loading

.. of dotnet/performance.

This can be done by adding perfForToUse parameter in runtime-wasm-perf.yml:

- template: /eng/pipelines/coreclr/perf-wasm-jobs.yml
  parameters:
    ...
    perfForkToUse:
      url: https://github.com/radical/performance
      branch: fix-build

Also:

  • change the default for the pipeline to run only sanity checks
  • And increase the timeout for the helix items from 15mins to 90mins, allowing the AOT jobs to run too

@radical
runtime-wasm-perf: add support for running against forks, and branches
cef6bd9 
.. of `dotnet/performance`.

This can be done by add these lines in `runtime-wasm-perf.yml`:

```
- template: /eng/pipelines/coreclr/perf-wasm-jobs.yml
  parameters:
    ...
    perfForkToUse:
      url: https://github.com/radical/performance
      branch: fix-build
```

Also, change the default for the pipeline to run only sanity checks.
@radical radical added arch-wasm WebAssembly architecture tenet-performance Performance related issue area-Infrastructure-mono labels Jul 30, 2022
@ghost ghost assigned radical Jul 30, 2022
@ghost
Copy link

ghost commented Jul 30, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. of dotnet/performance.

This can be done by adding perfForToUse parameter in runtime-wasm-perf.yml:

- template: /eng/pipelines/coreclr/perf-wasm-jobs.yml
  parameters:
    ...
    perfForkToUse:
      url: https://github.com/radical/performance
      branch: fix-build

Also, change the default for the pipeline to run only sanity checks.

Author: radical
Assignees: -
Labels:

arch-wasm, tenet-performance, area-Infrastructure-mono
Milestone: -

@radical
Copy link
Member Author

radical commented Jul 30, 2022

/azp runtime-wasm-perf

@azure-pipelines
Copy link

Command 'runtime-wasm-perf' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@radical
Copy link
Member Author

radical commented Jul 30, 2022

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jul 30, 2022

The dotnet/performance failures will be fixed by dotnet/performance#2542 .

@radical
Copy link
Member Author

radical commented Aug 1, 2022

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 1, 2022

runtime-wasm-perf is green.

@runfoapp runfoapp bot mentioned this pull request Aug 2, 2022
Closed
@radical
Copy link
Member Author

radical commented Aug 5, 2022

@adamsitnik Would you mind reviewing this PR? This, and #72431 .

adamsitnik
adamsitnik approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am going to use it myself very soon!

@radical radical merged commit 5a76f8c into dotnet:main Aug 5, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

@lewing lewing Awaiting requested review from lewing

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@DrewScoggins DrewScoggins Awaiting requested review from DrewScoggins

@LoopedBard3 LoopedBard3 Awaiting requested review from LoopedBard3

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono tenet-performance Performance related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @adamsitnik