Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It would be useful to have option for not generating TargetPlatformAttribute / SupportedOSPlatformAttribute #14836

Closed
buyaa-n opened this issue Dec 4, 2020 · 2 comments · Fixed by #29698
Closed

It would be useful to have option for not generating TargetPlatformAttribute / SupportedOSPlatformAttribute #14836

buyaa-n opened this issue Dec 4, 2020 · 2 comments · Fixed by #29698
Assignees
@ViktorHofer
Labels
Area-NetSDK
Milestone
Backlog

Comments

@buyaa-n
Copy link
Member

buyaa-n commented Dec 4, 2020 •
edited
Loading

Runtime repo no longer removing the platform from the TargetFramework string for net5.0 and above, this causes SupportedOSPlatformAttribute & TargetPlatformAttributes added by SDK for targeted platform in AssemblyInfo.cs file. This is useful for the Platform compat analyzer evaluate call site attributes. But there is some edge cases where we wouldn't like to generate the attributes and it would be great if SDK provide such option see more info

Related to dotnet/runtime#44257, #13453

cc @jeffhandley @ViktorHofer @Anipik @dsplaisted @sfoslund
@buyaa-n buyaa-n mentioned this issue Dec 14, 2020
Merged
@knoopr knoopr mentioned this issue Feb 1, 2021
Closed
@buyaa-n buyaa-n mentioned this issue Feb 3, 2021
Merged
@marcpopMSFT marcpopMSFT added the untriaged Request triage from a team member label Feb 25, 2021
@marcpopMSFT
Copy link
Member

@buyaa-n @jeffhandley I assume you've worked around this at this point and we can just leave this on the backlog as lower priority. Please confirm.

@marcpopMSFT marcpopMSFT added this to the Backlog milestone Jun 9, 2021
@marcpopMSFT marcpopMSFT added Area-NetSDK and removed untriaged Request triage from a team member labels Jun 9, 2021
@jeffhandley
Copy link
Member

This still causes some frustration for us in dotnet/runtime, but we've indeed worked around it. If there are any reports from external customers, that would be a good signal to increase the priority.

@buyaa-n buyaa-n mentioned this issue Aug 4, 2021
Open
@ericstj ericstj mentioned this issue Feb 1, 2022
Closed
ViktorHofer added a commit that referenced this issue Jan 2, 2023
@ViktorHofer
Add escape switch for TargetPlatform and SupportedOS attributes
f31d8cb 
Fixes #14836
@ViktorHofer ViktorHofer mentioned this issue Jan 2, 2023
Merged
@ViktorHofer ViktorHofer self-assigned this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ViktorHofer ViktorHofer

Labels
Area-NetSDK
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add escape switch for TargetPlatform and SupportedOS attributes dotnet/sdk
5 participants
@jeffhandley @joeloff @ViktorHofer @marcpopMSFT @buyaa-n