Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add escape switch for TargetPlatform and SupportedOS attributes #29698

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jan 2, 2023

Fixes #14836

Condition switches already exist for all the other assembly attributes.

cc @buyaa-n @jeffhandley

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It'll be nice to have these in place.

@ViktorHofer ViktorHofer merged commit a5ee32e into main Jan 2, 2023
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch January 2, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It would be useful to have option for not generating TargetPlatformAttribute / SupportedOSPlatformAttribute
2 participants